Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding name spacing to ApolloAPI.Object #94

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Adding name spacing to ApolloAPI.Object #94

merged 6 commits into from
Oct 23, 2023

Conversation

BobaFetters
Copy link
Member

-Name spacing our usage of ApolloAPI.Object in generated code in order to avoid conflicts with potential user defined custom scalar named 'Object'

Closes apollographql/apollo-ios#3258

@BobaFetters
Adding name spacing to ApolloAPI.Object
9db580c 
-Name spacing our usage of ApolloAPI.Object in generated code in order to avoid conflicts with potential user defined custom scalar named 'Object'
@BobaFetters
Updating name space usage
be77deb
@BobaFetters
Fixing tests
0e69eb1
@BobaFetters
More codegen test fixes
ea2efad
@BobaFetters
Fix SPM Codegen Test ordering
7dafb0e
@BobaFetters
Missed a comma
f0fbad9
@BobaFetters BobaFetters marked this pull request as ready for review October 20, 2023 20:33
calvincestari
calvincestari approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Zach, thanks for the quick fix!

Do you know what's up with the operation identifiers changing in StarWarsAPI? Is it just a module we didn't regenerate yet since the operation identifier work was done?

@calvincestari
Copy link
Member

Do you know what's up with the operation identifiers changing in StarWarsAPI? Is it just a module we didn't regenerate yet since the operation identifier work was done?

We should make sure it's not some changing default behaviour showing up in that module because it uses a different setting, etc.

@BobaFetters
Copy link
Member Author

Do you know what's up with the operation identifiers changing in StarWarsAPI? Is it just a module we didn't regenerate yet since the operation identifier work was done?

We should make sure it's not some changing default behaviour showing up in that module because it uses a different setting, etc.

Yea was trying to figure that out now, guessing maybe they just hadn't been regenerated but need to find out for sure

@BobaFetters
Copy link
Member Author

Ok yea looks like these weren't regenerated after that last fix in apollographql/apollo-ios#3163

@BobaFetters BobaFetters merged commit 42671a4 into main Oct 23, 2023
10 checks passed
@BobaFetters BobaFetters deleted the fix/object-scalar-clash-3258 branch October 23, 2023 17:01
BobaFetters added a commit that referenced this pull request Oct 23, 2023
@BobaFetters
Adding name spacing to ApolloAPI.Object (#94)
bb8e4f9
BobaFetters added a commit to apollographql/apollo-ios-codegen that referenced this pull request Oct 23, 2023
@BobaFetters
Adding name spacing to ApolloAPI.Object (apollographql/apollo-ios-dev#94
6a23fed 
)
BobaFetters pushed a commit that referenced this pull request Oct 23, 2023
split: apollo-ios - PR #94 - Adding name spacing to ApolloAPI.Object
10c06d7 
git-subtree-dir: apollo-ios
git-subtree-mainline: bb8e4f9
git-subtree-split: d73f454
BobaFetters pushed a commit that referenced this pull request Oct 23, 2023
Squashed 'apollo-ios-codegen/' changes from f2bbc9aa..6a23feda
0bf12b8 
6a23feda Adding name spacing to ApolloAPI.Object (#94)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 6a23feda4def07b977ab388ecd0a77db869c6450
BobaFetters pushed a commit that referenced this pull request Oct 23, 2023
split: apollo-ios-codegen - PR #94 - Adding name spacing to ApolloAPI…
7accd97 
….Object

git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: 10c06d7
git-subtree-split: 6a23feda4def07b977ab388ecd0a77db869c6450
BobaFetters pushed a commit that referenced this pull request Oct 23, 2023
pull: apollo-ios-pagination - PR #94 - Adding name spacing to ApolloA…
ca086dd 
…PI.Object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

@AnthonyMDev AnthonyMDev Awaiting requested review from AnthonyMDev

Assignees

@BobaFetters BobaFetters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Scalar type clashing a ApolloAPI type.
3 participants
@BobaFetters @calvincestari @AnthonyMDev