3599 mock custom scalar #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 2c749f196a790aa62ff29b96 |
calvincestari
approved these changes
Nov 5, 2025
...dedInTarget-InSchemaModule/Sources/TestApp/AnimalKingdomAPI/Schema/SchemaConfiguration.swift
Outdated
Show resolved
Hide resolved
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Nov 5, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
bdb9db0f2 3599 mock custom scalar (#838) git-subtree-dir: apollo-ios git-subtree-split: bdb9db0f2d15c30847e1371b9a06fa90ecbc71ac
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
git-subtree-dir: apollo-ios git-subtree-mainline: 292442f git-subtree-split: bdb9db0f2d15c30847e1371b9a06fa90ecbc71ac
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
88d92d525 3599 mock custom scalar (#838) git-subtree-dir: apollo-ios-codegen git-subtree-split: 88d92d52536f30ef8741ae8b31d0da8e3b9c0358
BobaFetters
pushed a commit
that referenced
this pull request
Nov 5, 2025
git-subtree-dir: apollo-ios-codegen git-subtree-mainline: a9240fc git-subtree-split: 88d92d52536f30ef8741ae8b31d0da8e3b9c0358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3599
This PR provides a new
static var defaultMockValue: SelfonScalarTypeandCustomScalarType. Generated mocks now use this property for initializer default values for custom scalars. This hides the SPI usage internal to the new computed property accessor.This PR also makes some changes to the TestCodegenConfigurations.