update tests to include federation v2.3 compatibility #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
commented
Feb 13, 2023
packages/compatibility/package.json
Outdated
| @@ -21,24 +21,24 @@ | |||
| "main": "dist/index.js", | |||
| "types": "dist/index.d.ts", | |||
| "dependencies": { | |||
| "@apollo/rover": "^0.10.0", | |||
| "@apollo/rover": "^0.11.1", | |||
| "debug": "^4.3.4", | |||
| "execa": "^5.1.1", | |||
There was a problem hiding this comment.
TODO: starting with v6 execa is pure ESM module and requires some additional code changes, will tackle it in a separate PR
dariuszkuc
force-pushed
the
fed2.3
branch
2 times, most recently
from
cb6b001
to
1ad69fe
Compare
dariuszkuc
changed the title
dariuszkuc
force-pushed
the
fed2.3
branch
3 times, most recently
from
7e90e16
to
2ec65f4
Compare
Apollo Federation Subgraph Compatibility Results
|
Adds tests for `@composeDirective` (fed v2.1) and `@interfaceObject` (fed v2.3). Schema changes: * update `@link` federation spec to v2.3 and add imports for `@composeDirective` and `@interfaceObject` ```graphql extend schema @link( url: "https://specs.apollo.dev/federation/v2.3", import: [ "@composeDirective", "@extends", "@external", "@inaccessible", "@interfaceObject", "@key", "@OverRide", "@provides", "@requires", "@Shareable", "@tag" ] ) ``` * apply `@link` to newly composed directive and `@composeDirective` on schema object (federation link import omitted for clarity) ```graphql extend schema @link(url: "https://myspecs.dev/myCustomDirective/v1.0", import: ["@Custom") @composeDirective(name: "@Custom") ``` * new `@custom` directive definition ```graphql directive @Custom on OBJECT ``` * apply `@custom` directive on `Product` type (other directives/fields omitted for clarity) ```graphql type Product @Custom ... { ... } ``` * declare new `@interfaceObject` type ```graphql type Inventory @interfaceObject @key(fields: "id") { id: ID! deprecatedProducts: [DeprecatedProduct!]! } ``` expected data set (deprecatedProduct is the existing object) ```js const inventory = { id: "apollo-oss", deprecatedProducts: [deprecatedProduct] } ``` --- Resolves: * apollographql#175 * apollographql#344
Apollo Federation Subgraph Compatibility Results
|
jeffjakub
approved these changes
Feb 14, 2023
Apollo Federation Subgraph Compatibility Results
|
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for
@composeDirective(fed v2.1) and@interfaceObject(fed v2.3).Schema changes:
@linkfederation spec to v2.3 and add imports for@composeDirectiveand@interfaceObject@linkto newly composed directive and@composeDirectiveon schema object (federation link import omitted for clarity)@customdirective definition@customdirective onProducttype (other directives/fields omitted for clarity)@interfaceObjecttypeexpected data set (deprecatedProduct is the existing object)
Resolves:
@interfaceObjectdirective #344