Avoid full reapplication of `cache-and-network` and `network-only` fetch policies after successful `fetchMore` #9504

Although these test updates may seem substantial, I believe this refactoring makes the tests more robust without changing what they test. To that end, it's important to note these tests are all passing at this point in the commit history, before any of the more substantive changes from PR #9504, and continue passing even after those changes are introduced, with relatively few additional test changes.

…veQuery.

#6916 (comment)

…cast.

Now that fetchMore's updateQuery callback is implemented in terms of the supported/documented cache.updateQuery method, I feel better about allowing fetchMore to continue to take an updateQuery callback. Also, everyone with any ability to migrate from updateQuery to InMemoryCache field policies has presumably already done so, so this warning is less useful now than it was following the release of AC3.

When `!diff.complete`, `oq.reobserveCacheFirst()` should behave exactly like `oq.reobserve()`, since the fetch policies `reobserveCacheFirst` modifies (`network-only` and `cache-and-network`) behave the same as the `cache-first` policy when cache results are incomplete.

This reverts commits d5463be and 0170f32, with a new test showing why the backup reobserveCacheFirst call in the finally block is important: sometimes the cache write doesn't change any data in the cache, so no broadcast happens, but we still need to deliver the final loading:false result for the fetchMore request.

#9504 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid full reapplication of `cache-and-network` and `network-only` fetch policies after successful `fetchMore` #9504

Avoid full reapplication of `cache-and-network` and `network-only` fetch policies after successful `fetchMore` #9504

Commits on Mar 29, 2022

Avoid full reapplication of cache-and-network and network-only fetch policies after successful fetchMore #9504

Avoid full reapplication of cache-and-network and network-only fetch policies after successful fetchMore #9504

Commits on Mar 29, 2022

Avoid full reapplication of `cache-and-network` and `network-only` fetch policies after successful `fetchMore` #9504

Avoid full reapplication of `cache-and-network` and `network-only` fetch policies after successful `fetchMore` #9504