-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more context to nextFetchPolicy
functions
#9222
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
98cb7b0
Provide more context to nextFetchPolicy functions.
benjamn 05d6deb
Add initialPolicy field to NextFetchPolicyContext.
benjamn f783ea2
Test different combinations of fetchPolicy/nextFetchPolicy.
benjamn ee48452
Documentation for nextFetchPolicy functions.
benjamn e557dce
Bump bundlesize limit to 29kB (now 28.98kB).
benjamn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change affect this scenario described here?
Wondering the behavior described in
4
will remain consistent:Thanks for your time and confirmation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dancrew32 Since you asked this question, I added some tests to verify the behavior should be the same as before, though it's possible I haven't understood/captured exactly what you mean. The tests exercise
defaultOptions.watchQuery.nextFetchPolicy
in a number of ways, for example. Please take a look at the new tests insrc/core/__tests__/fetchPolicies.ts
, try modifying them if you like, and let us know if anything seems worth adding to improve the test suite.One difference that might be worth calling out: if (and only if) you were already using a
nextFetchPolicy
function (uncommon, but supported since #6893 or AC v3.2.0), that function will now be called to handle thevariables-changed
event as well as theafter-fetch
event, whereas previously thefetchPolicy
was reset to its initial value whenvariables
changed with no chance to intercept that (possibly unwanted) behavior. I'm mildly concerned this could be a breaking change for existingnextFetchPolicy
functions that are not prepared to be called in thevariables-changed
case, though I'm hopeful most existingnextFetchPolicy
functions map their own previous result to itself (socache-first
stayscache-first
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My organization has never needed
nextFetchPolicy
in anyuseQuery
call sites, so this change shouldn't affect us. I can report back after we upgrade in the future, as I am interested in removingdefaultOptions
overrides in ourApolloClient
instantiation. Thanks for getting back to me, testing, and documenting all of this.