Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary language #9168

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Remove unnecessary language #9168

merged 1 commit into from
Dec 10, 2021

Conversation

AshKyd
Copy link
Contributor

@AshKyd AshKyd commented Dec 9, 2021

I'm trying to work out how to do something complex, and found this language alienating because being new to Apollo/Rest Link, there's nothing straightforward about it 😅

The paragraph works fine without it so I propose to remove it entirely.

Checklist:

  • [✔] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • [✔] Make sure all of the significant new logic is covered by tests

@AshKyd AshKyd requested a review from StephenBarlow as a code owner December 9, 2021 22:50
@apollo-cla
Copy link

@AshKyd: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks @AshKyd!

@benjamn benjamn merged commit e6af066 into apollographql:main Dec 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants