Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify written results using processed StoreObject in StoreWriter#processSelectionSet #8996

Merged
merged 16 commits into from
Nov 3, 2021
Merged

Identify written results using processed StoreObject in StoreWriter#processSelectionSet #8996

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5d01289
Decompose and export makeReadFieldFunction.
benjamn Oct 19, 2021
d3c5280
Use readField wrapper function in processSelectionSet.
benjamn Oct 25, 2021
4c5cb3d
Move policies.identify after field traversal in processSelectionSet.
benjamn Oct 22, 2021
043df16
Make policies.identify take a KeyFieldsContext.
benjamn Oct 22, 2021
fd33a40
Simplify keyFields extraction by removing AliasMap logic.
benjamn Oct 22, 2021
b5c6fab
Test that nested keyFields objects are stably stringified.
benjamn Sep 28, 2021
b880fcc
Export normalizeReadFieldOptions rather than makeReadFieldFunction.
benjamn Oct 25, 2021
f25b3d2
Assemble complete KeyFieldsContext from partial policies.identify input.
benjamn Oct 25, 2021
634e21b
Tolerate policies.identify failure when dataId already provided.
benjamn Oct 27, 2021
39d4f0f
Rely on existence of context.readField in keyFieldsFnFromSpecifier.
benjamn Nov 1, 2021
40fbe62
Hoist normalize function out of extractKeyPath.
benjamn Nov 3, 2021
1d01a67
Slightly better return type for collectSpecifierPaths.
benjamn Nov 3, 2021
ed125f3
Move array logic into extractKeyPath reducer to simplify extractKey.
benjamn Nov 3, 2021
cd99118
Cache immutable KeySpecifier-derived information to improve performance.
benjamn Nov 3, 2021
280ab72
Bump bundlesize limit to 28.45kB (now 28.44kB).
benjamn Nov 1, 2021
ce170ed
Mention PR #8996 in CHANGELOG.md.
benjamn Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mention PR #8996 in CHANGELOG.md.
  • Loading branch information
@benjamn
benjamn committed Nov 3, 2021
commit ce170ed6bbdc0e2ec32213606a68d8ef0907dff7
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
- Report single `MissingFieldError` instead of a potentially very large `MissingFieldError[]` array for incomplete cache reads, improving performance and memory usage. <br/>
[@benjamn](https://github.com/benjamn) in [#8734](https://github.com/apollographql/apollo-client/pull/8734)

- When writing results into `InMemoryCache`, each written object is now identified using `policies.identify` _after_ traversing the fields of the object (rather than before), simplifying identification and reducing duplicate work. If you have custom `keyFields` functions, they still receive the raw result object as their first parameter, but the `KeyFieldsContext` parameter now provides `context.storeObject` (the `StoreObject` just processed by `processSelectionSet`) and `context.readField` (a helper function for reading fields from `context.storeObject` and any `Reference`s it might contain, similar to `readField` for `read`, `merge`, and `cache.modify` functions). <br/>
[@benjamn](https://github.com/benjamn) in [#8996](https://github.com/apollographql/apollo-client/pull/8996)

- Ensure `cache.identify` never throws when primary key fields are missing, and include the source object in the error message when `keyFields` processing fails. <br/>
[@benjamn](https://github.com/benjamn) in [#8679](https://github.com/apollographql/apollo-client/pull/8679)

Expand Down