Remove recompose to avoid dependency on ua-parser-js
#8954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
Oct 22, 2021
Comment on lines
-11536
to
-11544
| "node_modules/ua-parser-js": { | ||
| "version": "0.7.24", | ||
| "resolved": "https://registry.npmjs.org/ua-parser-js/-/ua-parser-js-0.7.24.tgz", | ||
| "integrity": "sha512-yo+miGzQx5gakzVK3QFfN0/L9uVhosXBBO7qmnk7c2iw1IhL212wfA3zbnI54B0obGwC/5NWub/iT9sReMx+Fw==", | ||
| "dev": true, | ||
| "engines": { | ||
| "node": "*" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This removal is the primary goal of this PR.
brainkim
approved these changes
Oct 22, 2021
benjamn
added a commit
that referenced
this pull request
Oct 22, 2021
benjamn
added a commit
that referenced
this pull request
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ua-parser-jsnpm package was recently hijacked: faisalman/ua-parser-js#536This repository has a dependency chain involving
ua-parser-js:~/dev/apollo-client % npm ls ua-parser-js @apollo/client@3.5.0-rc.1 /Users/ben/dev/apollo-client └─┬ recompose@0.30.0 └─┬ fbjs@0.8.17 └── ua-parser-js@0.7.24Fortunately, that's the only dependency chain, and
recomposeis used only in development, in one HOC test.Since the
recomposepackage is used in only one test, and only itswithStatefunction is needed, I took the (MIT-licensed) liberty of extracting and adaptingwithState.jsfor continued use in that test.