Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document updateQuery/updateFragment #8867

Merged
merged 1 commit into from
Oct 4, 2021
Merged

document updateQuery/updateFragment #8867

merged 1 commit into from
Oct 4, 2021

Conversation

brainkim
Copy link
Contributor

Closes #8698

hwillson
hwillson approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @brainkim - thanks!

benjamn
benjamn approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content all looks great to me, though it would be nice to trigger a new build to fix the Netlify docs preview, since the error messages mention code added in this PR.

@brainkim
Copy link
Contributor Author

@benjamn Looks like an mdx error. Give me a sec while I pair every html tag in the entire document.

BTW I think writings docs is incredibly painful. How do people manage?

@hwillson
Copy link
Member

Vodka.

@brainkim brainkim force-pushed the brian-document-updateQuery-updateFragment branch 2 times, most recently from 8dee2bc to f9523c9 Compare September 30, 2021 00:02
StephenBarlow
StephenBarlow approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to merge whenever 3.5 is a thing

@benjamn benjamn changed the base branch from main to release-3.5 October 4, 2021 18:30
@brainkim brainkim force-pushed the brian-document-updateQuery-updateFragment branch from 7774a65 to b5e71bb Compare October 4, 2021 18:31
@brainkim brainkim merged commit 7648295 into release-3.5 Oct 4, 2021
@brainkim brainkim deleted the brian-document-updateQuery-updateFragment branch October 4, 2021 18:38
@hwillson hwillson mentioned this pull request Oct 12, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenBarlow StephenBarlow StephenBarlow approved these changes

@hwillson hwillson hwillson approved these changes

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document updateQuery and updateFragment
4 participants
@brainkim @hwillson @benjamn @StephenBarlow