Restore TVariables to useQuery return type #8801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Problem
useQuery
was clearly rewritten completely from 3.4 to 3.5, but its signature changed fromto
This causes the
TVariables
type arg to be thrown away, and then defaulted toOperationVariables
inQueryResult
. This causes assignability issues in TS in some cases. The issue can be demonstrated with a trivial generic hook that wraps a query hook:Notes
TVariables
are optional.npm run build
andnpm run test
worked fine with this change.@brainkim 🚎 👀