Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Missing cache result fields... warnings unless setLogVerbosity("debug") configured #8489

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Suppress Missing cache result fields... warnings unless setLogVerbosity("debug") configured #8489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a8f1c3
Update to ts-invariant@0.9.0 for invariant.debug.
benjamn Jul 12, 2021
2d89e22
Make 'Missing cache result fields...' warnings less noisy.
benjamn Jul 12, 2021
431ce2a
Mention PR #8489 in CHANGELOG.md.
benjamn Jul 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update to ts-invariant@0.9.0 for invariant.debug.
  • Loading branch information
@benjamn
benjamn committed Jul 12, 2021
commit 4a8f1c3a37e56d321890778b69f0e9ba8d72c433
2 changes: 1 addition & 1 deletion config/processInvariants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function transform(code: string, file: string) {

if (node.callee.type === "MemberExpression" &&
isIdWithName(node.callee.object, "invariant") &&
isIdWithName(node.callee.property, "log", "warn", "error")) {
isIdWithName(node.callee.property, "debug", "log", "warn", "error")) {
brainkim marked this conversation as resolved.
Show resolved Hide resolved
if (isDEVLogicalAnd(path.parent.node)) {
return;
}
Expand Down
13 changes: 3 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"optimism": "^0.16.1",
"prop-types": "^15.7.2",
"symbol-observable": "^4.0.0",
"ts-invariant": "^0.8.2",
"ts-invariant": "^0.9.0",
"tslib": "^2.1.0",
"zen-observable-ts": "^1.1.0"
},
Expand Down