Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve processing of options.nextFetchPolicy #8465

Merged
merged 11 commits into from
Jul 9, 2021
Merged

Improve processing of options.nextFetchPolicy #8465

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
add15f5
Avoid deleting options.nextFetchPolicy after applying it.
benjamn Jul 6, 2021
143e2ea
Specify which ObservableQuery operations run independently.
benjamn Jul 6, 2021
231ffbd
Reset options.fetchPolicy in ObservableQuery#setVariables.
benjamn Jul 6, 2021
1ab0161
Improve ObservableQuery nextFetchPolicy test.
benjamn Jul 6, 2021
1dcc2e8
Avoid specifying options.nextFetchPolicy for refetch operations.
benjamn Jul 6, 2021
4bd46ed
Avoid calling applyNextFetchPolicy in prepareObservableQueryOptions.
benjamn Jun 29, 2021
bdac212
Improve type for QueryData["previous"]["observableQueryOptions"].
benjamn Jul 7, 2021
83703c2
Reliably reset fetchPolicy to original value when variables change.
benjamn Jul 7, 2021
5d47432
Test that fetchPolicy is reset when variables change.
benjamn Jul 8, 2021
89126b6
Keep ObservableQuery initialFetchPolicy member private for now.
benjamn Jul 9, 2021
8a98eb9
Mention PR #8465 in CHANGELOG.md, as a "potentially disruptive" change.
benjamn Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid specifying options.nextFetchPolicy for refetch operations. 
Specifying options.nextFetchPolicy is unnecessary because refetch
operations receive a (disposable) copy of the ObservableQuery options,
so options.fetchPolicy does not need to be reset.
  • Loading branch information
@benjamn
benjamn committed Jul 9, 2021
commit 1dcc2e8a1a32aed3e4fd7cb431bcc4633a9fe0df
2 changes: 0 additions & 2 deletions src/core/ObservableQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,6 @@ export class ObservableQuery<
reobserveOptions.fetchPolicy = 'no-cache';
} else if (fetchPolicy !== 'cache-and-network') {
reobserveOptions.fetchPolicy = 'network-only';
// Go back to the original options.fetchPolicy after this refetch.
reobserveOptions.nextFetchPolicy = fetchPolicy || "cache-first";
}

if (variables && !equal(this.options.variables, variables)) {
Expand Down