Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Partial<TVariables> typing for fetchMore variables, rather than Pick<TVariables, K> #7476

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Use Partial<TVariables> typing for fetchMore variables, rather than Pick<TVariables, K> #7476

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b48e1
Use Partial<TVariables> typing for fetchMore variables.
ArnaudBarre Dec 14, 2020
6ba3522
Mention PR #7476 in CHANGELOG.md.
benjamn Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mention PR #7476 in CHANGELOG.md.
  • Loading branch information
@benjamn
benjamn committed Feb 9, 2021
commit 6ba3522b2fc23969cef8fb53b6a5b006dd3daad5
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ TBD
- Always use `POST` request when falling back to sending full query with `@apollo/client/link/persisted-queries`. <br/>
[@rieset](https://github.com/rieset) in [#7456](https://github.com/apollographql/apollo-client/pull/7456)

- The `FetchMoreQueryOptions` type now takes two instead of three type parameters (`<TVariables, TData>`), thanks to using `Partial<TVariables>` instead of `K extends typeof TVariables` and `Pick<TVariables, K>`. <br/>
[@ArnaudBarre](https://github.com/ArnaudBarre) in [#7476](https://github.com/apollographql/apollo-client/pull/7476)

### Documentation
TBD

Expand Down