Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify config/jest.config.js to consider only src/ directory. #7460

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Dec 11, 2020

Every time I build docs/ locally, my Jest tests go all haywire because Jest tries to find/run tests in docs/.cache/. I'm tired of debugging that problem over and over every few weeks, so I think we should explicitly restrict Jest to the only directory that's supposed to have any tests in it, src/.

Every time I build the docs/ locally, my Jest tests go haywire because
Jest tries to find/run tests found in docs/.cache/. I'm tired of debugging
that problem over again every few weeks, so I think we should restrict
Jest to the only directory that has any tests in it (that is, src/).
@benjamn
Copy link
Member Author

benjamn commented Dec 11, 2020

Since all of our tests are still running and passing, I'm going to go ahead and merge this:

Screen Shot 2020-12-11 at 2 31 08 PM

@benjamn benjamn merged commit ee501c8 into main Dec 11, 2020
@benjamn benjamn deleted the restrict-jest-to-src-directory branch December 11, 2020 19:32
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benjamn 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants