-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement useReactiveVar hook for consuming reactive variables in React components. #6867
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
45179b9
Generalize listening API for reactive variables.
benjamn 2f494c8
Implement useReactiveVar hook.
benjamn 141794c
Mention PR #6867 in CHANGELOG.md.
benjamn 002e199
Docs for useReactiveVar.
benjamn b9382b0
Avoid visiting new listeners added by other listeners.
benjamn b874104
Store broadcastable caches separately from listeners.
benjamn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid visiting new listeners added by other listeners.
A common pitfall when using forEach to iterate over a set of callback functions, thankfully caught by the tests I wrote.
- Loading branch information
commit b9382b07df1e74a3f634dd6c6805f80bd73a5a2d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const items = [...set]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have every reason to expect that to work, but TypeScript complains:
The ugly truth is that
--downlevelIteration
adds overhead to all...spread
operations (even theArray
-only ones), so that's unfortunately not an option for us, until we're comfortable dropping support for Internet Explorer.