Update apollo-link-schema.md #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@apollo/client/link/schema does not work as described in the documentation where `@apollo/link-schema` does with Apollo Client v3. Even if `@apollo/client/link/schema` is the way forward, it's currently broken and anyone reading this rn will hit errors. apollographql#6621
benjamn
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Happy to merge this until we fix the underlying problem. Thanks @stolinski!
benjamn
added a commit
that referenced
this pull request
Jul 16, 2020
This prevents the @apollo/client/link/schema CommonJS bundle (which is used by Node.js) from accidentally pulling in the entire dependency tree of graphql/execution/execute. This duplication not only increased the @apollo/client/link/schema CJS bundle size from 1.31kB to a whopping 22.6kB, but also caused instanceof to stop working reliably for types like GraphQLSchema, because there might be more than one definition of that constructor in play, and instanceof is sensitive to the exact constructor function you pass as the right-hand argument. Should fix #6621, allowing us to revert #6622. Thanks to @stolinsky for surfacing this issue.
benjamn
added a commit
that referenced
this pull request
Jul 16, 2020
This prevents the @apollo/client/link/schema CommonJS bundle (which is used by Node.js) from accidentally pulling in the entire dependency tree of graphql/execution/execute. This duplication not only increased the @apollo/client/link/schema CJS bundle size from 1.31kB to a whopping 22.6kB, but also caused instanceof to stop working reliably for types like GraphQLSchema, because there might be more than one definition of that constructor in play, and instanceof is sensitive to the exact constructor function you pass as the right-hand argument. Should fix #6621, allowing us to revert #6622. Thanks to @stolinski for surfacing this issue.
benjamn
added a commit
that referenced
this pull request
Jul 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apollo/client/link/schema does not work as described in the documentation where
@apollo/link-schemadoes with Apollo Client v3. Even if@apollo/client/link/schemais the way forward, it's currently broken and anyone reading this rn will hit errors.#6621
Checklist: