-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace options.isReference(ref, true) with options.canRead(ref). #6425
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,8 +21,8 @@ import { | |
Modifiers, | ||
ReadFieldFunction, | ||
ReadFieldOptions, | ||
IsReferenceFunction, | ||
ToReferenceFunction, | ||
CanReadFunction, | ||
} from '../core/types/common'; | ||
|
||
const DELETE: any = Object.create(null); | ||
|
@@ -136,7 +136,7 @@ export abstract class EntityStore implements NormalizedCache { | |
from: from || makeReference(dataId), | ||
} : fieldNameOrOptions, | ||
{ | ||
isReference: this.isReference, | ||
canRead: this.canRead, | ||
toReference: this.toReference, | ||
getFieldValue: this.getFieldValue, | ||
}, | ||
|
@@ -157,6 +157,7 @@ export abstract class EntityStore implements NormalizedCache { | |
storeFieldName, | ||
isReference, | ||
toReference: this.toReference, | ||
canRead: this.canRead, | ||
readField, | ||
}); | ||
if (newValue === DELETE) newValue = void 0; | ||
|
@@ -351,18 +352,13 @@ export abstract class EntityStore implements NormalizedCache { | |
: objectOrReference && objectOrReference[storeFieldName] | ||
) as SafeReadonly<T>; | ||
|
||
// Useful for determining if an object is a Reference or not. Pass true | ||
// for mustBeValid to make isReference fail (return false) if the | ||
// Reference does not refer to anything. | ||
public isReference: IsReferenceFunction = ( | ||
candidate, | ||
mustBeValid, | ||
): candidate is Reference => { | ||
return isReference(candidate) && | ||
// Note: this lookup will find IDs only in this layer and any layers | ||
// underneath it, even though there might be additional layers on | ||
// top of this layer, known only to the InMemoryCache. | ||
(!mustBeValid || this.has(candidate.__ref)); | ||
// Returns true for non-normalized StoreObjects and non-dangling | ||
// References, indicating that readField(name, objOrRef) has a chance of | ||
// working. Useful for filtering out dangling references from lists. | ||
public canRead: CanReadFunction = objOrRef => { | ||
return isReference(objOrRef) | ||
? this.has(objOrRef.__ref) | ||
: typeof objOrRef === "object"; | ||
Comment on lines
+359
to
+361
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Intentionally allowing |
||
}; | ||
|
||
// Bound function that converts an object with a __typename and primary | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a clear improvement, to me.