Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure last results are reset when working with partial data #6417

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Ensure last results are reset when working with partial data #6417

merged 1 commit into from
Jun 10, 2020

Commits on Jun 9, 2020

  1. Ensure last results are reset when working with partial data 

    Issue #6334 exposed a problem where the `lastResult` mechanism
we use to prevent duplicate subscription notifications (when
data hasn't changed) can unintentionally block certain results
from propagating through Apollo Client. This leads to issues
like loading states not being updated properly, due to new
partial results looking similar to last results.

This commit ensures that last results are properly cleared out
when new partial results come in.

Fixes #6334.
    @hwillson
    hwillson committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    4f3aa4d View commit details
    Browse the repository at this point in the history