Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] Eviction of fields by specific arguments #6141

Merged
merged 3 commits into from
May 8, 2020
Merged

[3.0] Eviction of fields by specific arguments #6141

merged 3 commits into from
May 8, 2020

Commits on May 8, 2020

  1. Add support for eviction of field names by arguments.

    @danReynolds @benjamn
    danReynolds authored and benjamn committed May 8, 2020
    Configuration menu
    Copy the full SHA
    45a697a View commit details
    Browse the repository at this point in the history

  2. Terminology: arguments instead of variables. 

    When calling cache.evict, we do not have a FieldNode, so we cannot supply
variables to be combined with the field's arguments, but must instead
provide the fully-resolved arguments object.

To make this work, the context argument of KeyArgsFunction no longer
provides context.variables, since that information is not always
available. The arguments passed as the first argument to the
KeyArgsFunction should be sufficient to compute the field identity.
    @benjamn
    benjamn committed May 8, 2020
    Configuration menu
    Copy the full SHA
    edff808 View commit details
    Browse the repository at this point in the history

  3. Mention PR apollographql#6141 in CHANGELOG.md.

    @benjamn
    benjamn committed May 8, 2020
    Configuration menu
    Copy the full SHA
    b009bbb View commit details
    Browse the repository at this point in the history