Testing utilities cleanup #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
commented
Oct 28, 2019
| @@ -5,8 +5,8 @@ import { makeReference } from '../utilities/graphql/storeUtils'; | |||
| import { ApolloLink } from '../link/core/ApolloLink'; | |||
| import { HttpLink } from '../link/http/HttpLink'; | |||
| import { InMemoryCache } from '../cache/inmemory/inMemoryCache'; | |||
| import { stripSymbols } from './utils/stripSymbols'; | |||
| import { withWarning } from './utils/wrap'; | |||
| import { stripSymbols } from '../utilities/testing/stripSymbols'; | |||
There was a problem hiding this comment.
@benjamn Just calling this out; I consolidated the testing utilities under a new location of utilities/testing. The previous __tests__/utils location worked, but I didn’t like how our rollup config looked when creating a separate testing bundle from the __tests__ dir. Let me know if the new location works - thanks!
Since we're combining all core + React testing utilities, let's get them out of the `__tests__` dir. It seemed a bit strange to create a separate `testing` bundle from a `__tests__` source location.
We're not using it in AC and it's easy enough to re-create if people need it.
The mocking utilities aren't mocks themselves, they're intended to help build mocks.
Make sure the utilities previously exported from the React testing location are included, and remove the old testing directories.
This method will allow us to avoid passing Promise reject functions as the first argument to mockSingleLink and the MockLink constructor, to avoid a breaking change for developers using those testing utilities.
These changes were accomplished using the recently added src/codemods/mockLinkRejection.ts codemod script, via jscodeshift: npm run build npx jscodeshift -t dist/codemods/mockLinkRejection.js src/**/*.ts
benjamn
force-pushed
the
testing-util-cleanup
branch
from
9f7c67e to
5730146
Compare
benjamn
reviewed
Nov 4, 2019
benjamn
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the overlap we have between Apollo Client and React mock testing utilities. All mock testing utilities have been pruned and moved into a new location (
/utilities/testing), alongside other testing utilities. The utilities we're exporting are bundled into a separate@apollo/client/testingbundle, and kept out of the main AC bundle.