Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-apollo.md #4467

Merged
merged 8 commits into from
Apr 8, 2019
Merged

Update react-apollo.md #4467

merged 8 commits into from
Apr 8, 2019

Conversation

papaponmx
Copy link
Contributor

I'm using v2.2.4 and the implemantation changed the other way around. I proposed this changes in order to update the documentation accordingly.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

I'm using `v2.2.4` and the implemantation changed the other way around. I proposed this changes in order to update the documentation accordingly.
@apollo-cla
Copy link

@papaponmx: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@papaponmx
Copy link
Contributor Author

Hey guys, I dig deeper into the problem. I'll update this PR in the weekend.

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @papaponmx!

@benjamn benjamn merged commit 67c2945 into apollographql:master Apr 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants