Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fragments.md #3869

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Update fragments.md #3869

merged 3 commits into from
Oct 8, 2018

Conversation

dansteren
Copy link
Contributor

@dansteren dansteren commented Aug 31, 2018

There is an issue where sometimes having operationName set to an empty string will result in an Error: GraphQL error: No operation named "" error (See #1760). Because the introspection query isn't given a name we should just remove the operationName property completely.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

There is an issue where sometimes having "operationName" set to an empty string will result in an [Error: GraphQL error: No operation named ""] error (See apollographql#1760). Replacing the empty string with null seems to fix this issue.
@apollo-cla
Copy link

@dansteren: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Because the introspection query doesn't have a name, we shouldn't be passing in the operationName prop at all.
@benjamn benjamn merged commit 3f336d2 into apollographql:master Oct 8, 2018
@benjamn
Copy link
Member

benjamn commented Oct 8, 2018

Thanks @dansteren!

@dansteren dansteren deleted the patch-1 branch October 8, 2018 22:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants