Use graphql v14.0.0 #3868
Closed
Use graphql v14.0.0 #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydenseric
reviewed
Sep 18, 2018
| @@ -45,7 +45,7 @@ | |||
| "graphql-anywhere": "file:../graphql-anywhere" | |||
| }, | |||
| "peerDependencies": { | |||
| "graphql": "0.11.7 || ^0.12.0 || ^0.13.0" | |||
| "graphql": "0.11.7 || ^0.12.0 || ^0.13.0 || ^14.0.0" | |||
There was a problem hiding this comment.
"0.11.7 - 14" is more succinct and easier to update.
|
What is that status of this PR ? |
|
duplicated with #3978 |
|
This was addressed in b082c8b. Thanks @kamilkisiela! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
packages/*/package-lock.jsonbecause it's not something lerna produce and it's just trash. Someone just rannpm installin subdirectories and that's why it got here.apollo-cache-inmemoryhad no^14.0.0in peerDeps.Related PR: apollographql/apollo-link#777
Apollo Angular works with new graphql too: kamilkisiela/apollo-angular#795
@hwillson one question, have you guys changed renovate's configuration to not create PRs? I see there's a branch available.