Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client, rest, and export to known directives in apollo-utilities #2949

Merged
merged 2 commits into from
Feb 2, 2018

Conversation

peggyrayzis
Copy link
Contributor

This PR fixes an issue with apollo-link-state where adding the @client directive to the object key in #2710 broke cache.writeData:
apollographql/apollo-link-state#187

This fix is temporary until we can think of a more robust solution for directional directives like @client and @rest. With directional directives, the cache doesn't care about the directive since it only impacts the execution, not the results. This is in contrast to translational directives like @uppercase, where the result is altered.

@apollo-cla
Copy link

Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Messages
📖

Please add your name and email to the AUTHORS file (optional)

Generated by 🚫 dangerJS

@jbaxleyiii jbaxleyiii merged commit bb26dc0 into apollographql:master Feb 2, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants