Remove orphan promise #1256
Merged
Remove orphan promise #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1255
|
lgtm 👍 |
mdebbar
reviewed
Feb 18, 2017
| if (isEqual(newVariables, this.variables) && !tryFetch) { | ||
| // If we have no observers, then we don't actually want to make a network | ||
| // request. As soon as someone observes the query, the request will kick | ||
| // off. For now, we just store any changes. (See #1077) | ||
| if (this.observers.length === 0) { | ||
| return nullPromise; | ||
| return new Promise((resolve) => resolve()); |
There was a problem hiding this comment.
Isn't this equivalent to return Promise.resolve() ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1255