Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor #12390

Open
wants to merge 3 commits into
base: release-4.0
Choose a base branch
from
Open

Minor refactor #12390

wants to merge 3 commits into from

Conversation

jerelmiller
Copy link
Member

Did a bit of unraveling of a couple used/unused functions in QueryManager and noticed a chance to remove some duplicate functionality.

@jerelmiller jerelmiller requested a review from a team as a code owner February 24, 2025 23:33
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 51919d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svc-apollo-docs
Copy link

svc-apollo-docs commented Feb 24, 2025

❌ Docs preview failed

The preview failed to build.

Build ID: 083232881bd34376cfe9b6fa

Errors

react/api/react/hooks

  • Cannot find module '@microsoft/tsdoc/schemas/tsdoc.schema.json' from '/var/task/node_modules/.pnpm/@microsoft+tsdoc-config@0.17.0/node_modules/@microsoft/tsdoc-config/lib'
    react/data/mutations

  • Cannot find module '@microsoft/tsdoc/schemas/tsdoc.schema.json' from '/var/task/node_modules/.pnpm/@microsoft+tsdoc-config@0.17.0/node_modules/@microsoft/tsdoc-config/lib'
    react/data/queries

  • Cannot find module '@microsoft/tsdoc/schemas/tsdoc.schema.json' from '/var/task/node_modules/.pnpm/@microsoft+tsdoc-config@0.17.0/node_modules/@microsoft/tsdoc-config/lib'

@jerelmiller jerelmiller changed the base branch from main to release-4.0 February 24, 2025 23:33
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 51919d2
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/67bd01d8a4076400087f3fe8
😎 Deploy Preview https://deploy-preview-12390--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Feb 24, 2025

npm i https://pkg.pr.new/@apollo/client@12390

commit: 51919d2

Copy link
Contributor

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.97 KB (-9.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 30.49 KB (-9.34% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.17 KB (-7.08% 🔽)
import { ApolloProvider } from "dist/react/index.js" (production) 1.15 KB (-7.11% 🔽)
import { useQuery } from "dist/react/index.js" 4.58 KB (-12.15% 🔽)
import { useQuery } from "dist/react/index.js" (production) 3.75 KB (-12.79% 🔽)
import { useLazyQuery } from "dist/react/index.js" 4.96 KB (-13.06% 🔽)
import { useLazyQuery } from "dist/react/index.js" (production) 4.13 KB (-13.6% 🔽)
import { useMutation } from "dist/react/index.js" 3.31 KB (-8.54% 🔽)
import { useMutation } from "dist/react/index.js" (production) 2.6 KB (-8.33% 🔽)
import { useSubscription } from "dist/react/index.js" 4.17 KB (-5.63% 🔽)
import { useSubscription } from "dist/react/index.js" (production) 3.29 KB (-5.37% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" 5.43 KB (-7.52% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.21 KB (-7.25% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" 4.92 KB (-8.35% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.67 KB (-8.87% 🔽)
import { useLoadableQuery } from "dist/react/index.js" 4.98 KB (-8.76% 🔽)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.73 KB (-9.11% 🔽)
import { useReadQuery } from "dist/react/index.js" 2.17 KB (-36.68% 🔽)
import { useReadQuery } from "dist/react/index.js" (production) 2.1 KB (-37.43% 🔽)
import { useFragment } from "dist/react/index.js" 1.87 KB (-20.79% 🔽)
import { useFragment } from "dist/react/index.js" (production) 1.82 KB (-21.17% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/__cjs/index.cjs" 43.95 KB (+100% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/__cjs/index.cjs" (production) 41.47 KB (+100% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants