-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove check for WeakMap
, WeakSet
and symbols
#12388
base: release-4.0
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2f2727c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
commit: |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
return true; | ||
} | ||
} | ||
export { useSyncExternalStore } from "use-sync-external-store/shim/index.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer it if we wouldn't have to point at a specific file as an implementation detail. Can we keep this change out of this PR? I generally have an idea to tackle this differently, so I'd try that first.
Closes #12188
Removes some of the checks for
WeakMap
,WeakSet
and symbols and enforces that Apollo Client is running in a more modern environment.This PR also removes our custom
useSyncExternalStore
implementation in favor of the official shim.