Build tooling 3/? - export conditions #12385

phryneas · 2025-02-20T10:23:43Z

No description provided.

changeset-bot · 2025-02-20T10:23:49Z

🦋 Changeset detected

Latest commit: 95abc11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svc-apollo-docs · 2025-02-20T10:23:49Z

⚠️ Docs preview not attached to branch

The preview was not built because the PR's base branch release-4.0 is not in the list of sources.

An Apollo team member can comment one of the following commands to dictate which branch to attach the preview to:

!docs set-base-branch version-2.6
!docs set-base-branch main

Build ID: 6e5ec58a966f50c9b6e14041

netlify · 2025-02-20T10:25:02Z

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	`95abc11`
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67c1d6508fc5a2000840b9d9
😎 Deploy Preview	https://deploy-preview-12385--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pkg-pr-new · 2025-02-20T10:25:07Z

npm i https://pkg.pr.new/@apollo/client@12385

commit: 95abc11

github-actions · 2025-02-20T10:25:35Z

size-limit report 📦

Path	Size
import { ApolloClient, InMemoryCache, HttpLink } from "dist/__cjs/index.cjs"	0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/__cjs/index.cjs" (production)	0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	0 B (-100% 🔽)
import { ApolloProvider } from "dist/react/index.js"	0 B (-100% 🔽)
import { ApolloProvider } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useLazyQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useLazyQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useMutation } from "dist/react/index.js"	0 B (-100% 🔽)
import { useMutation } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useSubscription } from "dist/react/index.js"	0 B (-100% 🔽)
import { useSubscription } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useSuspenseQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useBackgroundQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useLoadableQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useLoadableQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useReadQuery } from "dist/react/index.js"	0 B (-100% 🔽)
import { useReadQuery } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { useFragment } from "dist/react/index.js"	0 B (-100% 🔽)
import { useFragment } from "dist/react/index.js" (production)	0 B (-100% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (CJS)	43.41 KB (+100% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production) (CJS)	38.83 KB (+100% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client"	29.42 KB (+100% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "@apollo/client" (production)	28.97 KB (+100% 🔺)
import { ApolloProvider } from "@apollo/client/react"	983 B (+100% 🔺)
import { ApolloProvider } from "@apollo/client/react" (production)	983 B (+100% 🔺)
import { useQuery } from "@apollo/client/react"	3.5 KB (+100% 🔺)
import { useQuery } from "@apollo/client/react" (production)	3.47 KB (+100% 🔺)
import { useLazyQuery } from "@apollo/client/react"	3.85 KB (+100% 🔺)
import { useLazyQuery } from "@apollo/client/react" (production)	3.82 KB (+100% 🔺)
import { useMutation } from "@apollo/client/react"	2.34 KB (+100% 🔺)
import { useMutation } from "@apollo/client/react" (production)	2.33 KB (+100% 🔺)
import { useSubscription } from "@apollo/client/react"	3.11 KB (+100% 🔺)
import { useSubscription } from "@apollo/client/react" (production)	3.09 KB (+100% 🔺)
import { useSuspenseQuery } from "@apollo/client/react"	4.31 KB (+100% 🔺)
import { useSuspenseQuery } from "@apollo/client/react" (production)	4.28 KB (+100% 🔺)
import { useBackgroundQuery } from "@apollo/client/react"	3.85 KB (+100% 🔺)
import { useBackgroundQuery } from "@apollo/client/react" (production)	3.82 KB (+100% 🔺)
import { useLoadableQuery } from "@apollo/client/react"	3.91 KB (+100% 🔺)
import { useLoadableQuery } from "@apollo/client/react" (production)	3.89 KB (+100% 🔺)
import { useReadQuery } from "@apollo/client/react"	1.87 KB (+100% 🔺)
import { useReadQuery } from "@apollo/client/react" (production)	1.86 KB (+100% 🔺)
import { useFragment } from "@apollo/client/react"	1.63 KB (+100% 🔺)
import { useFragment } from "@apollo/client/react" (production)	1.6 KB (+100% 🔺)

phryneas · 2025-02-20T17:28:50Z

There's still something going on with side-effects, we need to look into this - from running size-limit locally:


    dist/errors/index.js:1:7:
      1 │ import "../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/utilities/globals/index.js" was marked as having no side effects [ignored-bare-import]

    dist/cache/index.js:1:7:
      1 │ import "../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/utilities/globals/index.js" was marked as having no side effects [ignored-bare-import]

    dist/link/core/index.js:1:7:
      1 │ import "../../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/utilities/globals/index.js" was marked as having no side effects [ignored-bare-import]

    dist/link/http/index.js:1:7:
      1 │ import "../../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/utilities/globals/index.js" was marked as having no side effects [ignored-bare-import]

    dist/link/utils/index.js:1:7:
      1 │ import "../../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/cache/inmemory/fixPolyfills.js" was marked as having no side effects [ignored-bare-import]

    dist/cache/inmemory/inMemoryCache.js:4:7:
      4 │ import "./fixPolyfills.js";
        ╵        ~~~~~~~~~~~~~~~~~~~

  "sideEffects" is false in the enclosing "package.json" file:

    dist/package.json:20:2:
      20 │   "sideEffects": false,
         ╵   ~~~~~~~~~~~~~

▲ [WARNING] Ignoring this import because "dist/utilities/globals/index.js" was marked as having no side effects [ignored-bare-import]

    dist/react/index.js:1:7:
      1 │ import "../utilities/globals/index.js";
        ╵        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

phryneas · 2025-02-20T17:54:20Z

src/cache/inmemory/inMemoryCache.ts

 // Make builtins like Map and Set safe to use with non-extensible objects.
+// TODO: this needs to be removed for 4.0, so we really don't have side effects.
+// that means we have to find an alternative means for the React Native fixes in there.
 import "./fixPolyfills.js";


pointing this out as a TODO

jorenbroekema · 2025-03-03T09:44:31Z

package.json

@@ -30,11 +30,56 @@
    "url": "https://github.com/apollographql/apollo-client/issues"
  },
  "homepage": "https://www.apollographql.com/docs/react/",
+  "exports": {
+    ".": "./src/index.ts",


Wouldn't these be pointing to compiled JS files instead of publishing the TS source files? Generally speaking, typescript projects should publish compiled JS to NPM

phryneas added 2 commits February 19, 2025 13:30

move entry points out of entryPoints into package.json exports

b36410d

build working, jest not working

fe8bbba

phryneas added 13 commits February 20, 2025 11:58

formatter

30cf850

fixup jest

aa3511b

add custom resolver, explicitly import __DEV__

fa47016

prettier

c9212db

missing import

62d20bb

import __DEV__ when inserted by processInvariants

f597f34

no more type checking in jest

8d86168

use same tsconfig for tests

cb9b794

reorder ci steps

e314e8e

update api reports

60eae09

use conditions in size limits

25d14ab

fix up a bunch of things

064c637

attw green

67049a1

phryneas added 3 commits February 20, 2025 18:40

remove side-effect import for utilities/globals

205c575

mark __DEV__ export as boolean in all envs

4483d10

add section for .d.cts

6a31945

phryneas commented Feb 20, 2025

View reviewed changes

phryneas added 5 commits February 28, 2025 14:37

size-limit plugin, more dev mode

2b55fe4

work around api extractor package resolution

5f1ac78

knip: ignore size-limit-apollo-plugin

b9fa213

some more cleanup

6000bc7

add step to script

c6d930f

fixup

95abc11

jorenbroekema reviewed Mar 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build tooling 3/? - export conditions #12385

Build tooling 3/? - export conditions #12385

phryneas commented Feb 20, 2025

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

svc-apollo-docs commented Feb 20, 2025 •

edited

Loading

netlify bot commented Feb 20, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

phryneas commented Feb 20, 2025

phryneas Feb 20, 2025

jorenbroekema Mar 3, 2025

Build tooling 3/? - export conditions #12385

Are you sure you want to change the base?

Build tooling 3/? - export conditions #12385

Conversation

phryneas commented Feb 20, 2025

changeset-bot bot commented Feb 20, 2025 • edited Loading

🦋 Changeset detected

svc-apollo-docs commented Feb 20, 2025 • edited Loading

⚠️ Docs preview not attached to branch

netlify bot commented Feb 20, 2025 • edited Loading

✅ Deploy Preview for apollo-client-docs ready!

pkg-pr-new bot commented Feb 20, 2025 • edited Loading

github-actions bot commented Feb 20, 2025 • edited Loading

size-limit report 📦

phryneas commented Feb 20, 2025

phryneas Feb 20, 2025

Choose a reason for hiding this comment

jorenbroekema Mar 3, 2025

Choose a reason for hiding this comment

changeset-bot bot commented Feb 20, 2025 •

edited

Loading

svc-apollo-docs commented Feb 20, 2025 •

edited

Loading

netlify bot commented Feb 20, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 20, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading