-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to RxJS #12384
Open
jerelmiller
wants to merge
298
commits into
release-4.0
Choose a base branch
from
jerel/rxjs
base: release-4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,473
−3,412
Open
Switch to RxJS #12384
Changes from 1 commit
Commits
Show all changes
298 commits
Select commit
Hold shift + click to select a range
d18be9e
Use rxjs observable in useBackgroundQuery tests
jerelmiller 2fc6919
Use rxjs observable in useFragment tests
jerelmiller 5deacdf
Use rxjs observable in useLazyQuery tests
jerelmiller 9067e17
Use rxjs observable in useLoadableQuery tests
jerelmiller 27ebacb
Use rxjs observable in useQuery tests
jerelmiller 739390b
Use rxjs observable in useMutation tests
jerelmiller ab07956
Use rxjs observable in useQuery tests
jerelmiller 68a2917
Use rxjs observable in useSuspenseQuery tests
jerelmiller 184633a
Use rxjs observable in useSubscription tests
jerelmiller d2b1c63
Use rxjs observable in QueryReference tests
jerelmiller 3989d8c
Use rxjs observable in createQueryPreloader tests
jerelmiller d7b9b80
Use rxjs observable in ObservableStream tests
jerelmiller 2809858
Use rxjs observable in scenarios
jerelmiller 530976b
Use rxjs observable in MockedProvider tests
jerelmiller 08155af
Use rxjs observable in asyncMap tests
jerelmiller 195e815
Use rxjs observable in Concast tests
jerelmiller 2137931
Fix type in ObservableQuery
jerelmiller bb77ae5
Use partial observer in ObservableQuery
jerelmiller e6455a7
Use mergeMap/from instead of asyncMap
jerelmiller b833d87
Use rxjs utils to handle mapping over result
jerelmiller d342a5a
Remove asyncMap
jerelmiller bcd9296
Use partial observer in concast
jerelmiller af96eb7
Use rxjs observer type in iteration
jerelmiller a0b6792
Remove SubscriptionCurrentObserver type
jerelmiller 4f7be6b
Use rxjs for urql utility
jerelmiller f73d0bd
Don't export zen observable Observable
jerelmiller b46d276
Remove Observable exports from zen observable
jerelmiller 6f05daa
Use Observer type from rxjs
jerelmiller 3994cad
Use observer type from rxjs
jerelmiller cae48f6
Remove zen-observable-ts
jerelmiller c755020
Replace concast with call to execute and pipe to get obsrvable from link
jerelmiller b4b4127
Use the asyncScheduler for reporting cache values
jerelmiller b91f2a9
Add todo comment
jerelmiller e5db318
Share the observable
jerelmiller 0aa56a5
Adjust test
jerelmiller 150eedf
Use ObservableStream in test
jerelmiller 1f3b2e5
Adjust todo comment
jerelmiller 0d18782
Remove query from in map for error
jerelmiller f738a30
Update test to get it to pass
jerelmiller 5b1950b
Update test
jerelmiller 68b0372
Use subject for test
jerelmiller 3128cb4
Add emit value to ensure test succeeds
jerelmiller 33b7d31
Disable test for now. Add todo comment
jerelmiller 1a96ff1
Tweak todo comment
jerelmiller f21a3d5
Switch to shareReplay for observable emitted from link
jerelmiller 963eb92
Add helper that removes query from inFlightObservables for any event
jerelmiller 2f7b630
Ensure query is remove from inFlightLinkObservables on complete event
jerelmiller bb6d1d0
Remove temp fix in test
jerelmiller f53024f
Tweak todo comment
jerelmiller 9b20e8e
Change assertion for checking inFlightObservables in test
jerelmiller 55c8af2
Remove unused import
jerelmiller b7d4256
Rework tests that check for awaitRefetchQueries
jerelmiller 79ebb3f
Ensure underlying observable is unsubscribed when refCount is 0
jerelmiller c65ca9e
Skip test for now
jerelmiller a63c7c4
Add todo comment
jerelmiller 2dad98f
Use non-deprecated version of subscribe
jerelmiller 4d3b735
Use Subscribable interface for ObservableStream
jerelmiller 21789f0
Add todo comment
jerelmiller 8f55987
Start working with making ObservableQuery a subscribable with inner s…
jerelmiller 2e813e6
Call next/error when reporting error
jerelmiller beca353
Use defaultSubscriptionObserverErrorCallback
jerelmiller cf3cd5f
Bind unsubscribe in ObservableStream
jerelmiller 7eb6c40
Ensure subscribe method is bound
jerelmiller c48889c
Check subject.observed when polling and ensure its kicked off correctly
jerelmiller 49180a0
Add todo comment
jerelmiller 85a4c4d
Increase timeout in test
jerelmiller abbca66
Tear down query when an error occurs
jerelmiller daa2772
Update hasObservers to return subject.observed
jerelmiller 4612291
Revert change in polling
jerelmiller 4d9568e
Enable test that was previously failing
jerelmiller 1a46cec
Disable test with todo comment
jerelmiller 04f49d5
Use hasObservers in setVariables
jerelmiller 5a5d5d6
Skip test for now
jerelmiller 8db2d52
Emit loading state for no-cache query
jerelmiller 7fc5a20
Emit loading with network-only and full result
jerelmiller a0dfd52
Add some todo comments
jerelmiller 359b42f
Disable part of the test for now
jerelmiller 4a65cd8
Add todo comment
jerelmiller 2b98c74
Add todo comment and skip test
jerelmiller 812a7a8
Add additional loading state to test
jerelmiller c4f4ec6
Use async/await in test
jerelmiller ecc52f2
Add some todo comments on possible deprecations
jerelmiller f8790df
Delete commented code
jerelmiller 47fab55
Skip failing test
jerelmiller 06bedfd
Update constructor
jerelmiller e777875
Update exports snapshot
jerelmiller 3e80afc
Remove condition that emits on no-cache and swap skipped tests
jerelmiller 4df8b72
Ensure pipe happens on observable instead of subject
jerelmiller 0a1c00f
Update optimistic tests to use native .pipe
jerelmiller cdfdef5
Update number of expected assertions
jerelmiller 767fe06
Remove unneeded casts
jerelmiller b218e8e
Use this.hasObsevers in result()
jerelmiller 9bc1d23
Don't use async function for Observable
jerelmiller 51fdd01
Async emit value from link
jerelmiller ae20893
Add todo comment
jerelmiller f16c337
Update number of assertions
jerelmiller 144f13b
Mask result emitted to subject
jerelmiller 2ed52aa
No more iterate observers in ObservableQuery
jerelmiller ea504f3
Remove observer tracking
jerelmiller e69f7db
Add todo comment
jerelmiller 13495cb
Ensure all sources returned are observables
jerelmiller 48a213e
Return observable from fetchQueryByPolicy instead of sources array.
jerelmiller 949f4e9
Rename variable
jerelmiller 1678c87
Use rxjs observables when fetching instead of concast
jerelmiller 711da08
Rename property to observable
jerelmiller dc37c2f
Call complete on the subject when cleaning up cancel function
jerelmiller 9416f24
Call error before cleanup when cancelling
jerelmiller 86f53a1
Don't terminate the observable when an error occurs
jerelmiller 54c848c
Use subscription tracking when executing reobserve
jerelmiller a539db0
Track observable
jerelmiller 6052ff1
Stop tracking concast
jerelmiller 8a1e5f7
Update tests to demonstrate that observable no longer terminates on e…
jerelmiller 7867828
Emit value async in test
jerelmiller 56d02d0
Ensure observable is multicast
jerelmiller 1133442
Add todo comments
jerelmiller bee20c0
Add todo test
jerelmiller 74a78e1
Don't unsubscribe from link if unsubscribe from observable query befo…
jerelmiller f690a9e
Add changeset
jerelmiller 6069a7c
Add another changeset
jerelmiller 2d6b392
Skip test that checks console.error
jerelmiller c3a3e74
Remove default error handler
jerelmiller 62f38fb
Update todo comment
jerelmiller 1720b66
Stop using async scheduler
jerelmiller 2817068
Update test with change to unsubscribe
jerelmiller af00283
Add test for race condition
jerelmiller 536775c
Remove unneeded type casting in test
jerelmiller ce4e041
Add todo comment
jerelmiller 7e30d28
Wrap initial call to reobserve in setTimeout
jerelmiller 80af5bb
Wrap call in setTimeout
jerelmiller 8b5cc44
Add back asapScheduler to allow reobserve to kick off synchronously
jerelmiller d22706e
Move asapScheduler to end of chain
jerelmiller f863bae
Remove asapScheduler again. Update test to deliver results async
jerelmiller f2e4115
Update test for returned errors
jerelmiller 6a0dfec
Copy mockFetchQuery
jerelmiller 717abed
Add todo comment
jerelmiller 116de86
Update more tests that check for errors
jerelmiller 704e8e7
Emit a value in the test to avoid the error
jerelmiller f6844e1
Update todo comment
jerelmiller 3ccebcf
Update more tests that check for rejected errors
jerelmiller 79f9477
Update test for new behavior after error
jerelmiller c506109
Update more checks against error case
jerelmiller 6a99e6c
Update expected behavior on error and resolvers
jerelmiller 9d018b9
Add additional emit values in test
jerelmiller 542a648
Update test for setOptions with standby
jerelmiller 36883f6
Update test that checks for throwing behavior
jerelmiller dfd0a2d
Use async await in test
jerelmiller 614c207
Update local state test
jerelmiller 89c0176
Ensure link completes
jerelmiller 8115584
Update error handling in test
jerelmiller 136b082
Change test description
jerelmiller 44dd567
Add a check in filter for no-cache fetch policy
jerelmiller b92d6a4
Update test handling error
jerelmiller 62c3583
Use type inference
jerelmiller 7023a53
Update test since results are delivered synchronously
jerelmiller 4b7e4e9
Update test that checks error handling
jerelmiller 72c6f5e
Assert promise rejects
jerelmiller a70c67b
Update check on error
jerelmiller 320a405
Temp update test that changes to standby
jerelmiller 1155555
Tweak test that handles network error
jerelmiller ddb7ff3
Update failing fetchMore test
jerelmiller 6968210
Copy setup inline to fix test
jerelmiller 2e966e0
Fix number of assertions
jerelmiller 88c5c54
Fix assertion on result
jerelmiller 3f866a2
Update number of assertions
jerelmiller 008641d
Add errors property to some checks
jerelmiller b33c55e
Use the value passed to the next handler in useQuery
jerelmiller f1e0384
Fix some checks against networkStatus for error cases in useQuery tests
jerelmiller c505ffa
Set data to undefined when result is partial
jerelmiller 397aa92
Async emit next value in test
jerelmiller ddc7ba4
Use asapScheduler to deliver notification to useQuery
jerelmiller c92fb91
Emit value async in test
jerelmiller a5aa756
Delay event
jerelmiller 69d2c81
Update assertion
jerelmiller 71ee1a2
Check for errors property in error tests
jerelmiller 4237227
Update test with proper network status
jerelmiller f411bb4
Emit value async
jerelmiller a3374cb
Remove Concast
jerelmiller 098a3cc
Remove unneeded onError handler
jerelmiller f3b6e5a
Inline onNext
jerelmiller 53357d6
Run formatting on tests
jerelmiller 8fa180f
Wrap in act
jerelmiller a6c3bda
Wrap in act
jerelmiller a4ada8a
Wrap in act
jerelmiller 6fd25c4
Wrap in act
jerelmiller 892a165
Wrap in act
jerelmiller b76bc22
Wrap in act
jerelmiller 1eabfa3
Handle errors in the next handler
jerelmiller 9d690ec
Wrap in act
jerelmiller d540807
Wrap in act
jerelmiller f0cf062
Handle errors returned in deferred queries
jerelmiller cc408a8
Remove error handler in QueryReference
jerelmiller 05ac637
Add todo comment
jerelmiller 42734b2
Remove check on empty object
jerelmiller e507cef
Remove unneeded subscribeAfterError method
jerelmiller b1dbc57
Add errors property in useLazyQuery tests
jerelmiller 6ff1987
Add changeset
jerelmiller b9a73c7
Update tests assertions on cache-only queries with partial data
jerelmiller 74c12c0
Remove unneeded symbol-observable package
jerelmiller 47c9fdd
Update exports snapshot
jerelmiller c116190
Fix unused variable issue
jerelmiller 6d8428b
Rename fetchConcastWithInfo to fetchObservableWithInfo
jerelmiller eab16ba
Use reobserve directly in useLazyQuery
jerelmiller 3c2de2a
Combine reobserve and reobserveAsConcast
jerelmiller 3c4f459
Rename everything with concast in the name
jerelmiller b083e92
Update package-lock in memory
jerelmiller 55778f2
Fix memory tests
jerelmiller a4645d3
Wrap in setTimeout
jerelmiller 49867aa
Fix test in React 17
jerelmiller eee4397
Add comment
jerelmiller 181e464
Use type inference
jerelmiller f7bfabc
Use firstValueFrom in result()
jerelmiller 445aa04
Update todo comment
jerelmiller 97c4f43
Use this instead of self
jerelmiller b7276e9
Add back old implementation of result()
jerelmiller 6374874
Add changeset
jerelmiller 1d4ea9d
Add another changeset
jerelmiller 825a3ad
Use firstValueFrom in persisted-queries tests
jerelmiller 4420239
Use firstValueFrom in fromPromise tests
jerelmiller 0e9ebe5
Remove toPromise in remaining tests
jerelmiller d5c4d99
Remove toPromise helper
jerelmiller 526266f
Remove fromPromise helper
jerelmiller 13f4e99
Replace fromError with throwError in batchHttpLink
jerelmiller 80a7774
Replace fromError with throwError in HttpLink
jerelmiller b4cbedd
Replace fromError with throwError in retryLink tests
jerelmiller ae1d4c2
Remove console logs in retryLink tests
jerelmiller 30d0cc7
Remove fromError helper
jerelmiller 3131d82
Add changesets for removed utilities
jerelmiller cc64c7a
Update exports
jerelmiller 8ce76f2
Rerun api report
jerelmiller 68ed3f2
Remove todo and enable test with appropriate changes
jerelmiller fd9d464
Add todo comment
jerelmiller fba30ee
Remove iterateOberversSafely
jerelmiller cfebd57
Add more changesets
jerelmiller 0428b70
Remove error listener that tears down observable query
jerelmiller ed0cc1a
Rename obs to linkObservable
jerelmiller 129fb13
Rename this.subscription to linkSubscription
jerelmiller 279bfae
Update API report
jerelmiller 44d6a6f
Restore test to original
jerelmiller 4b03336
Add comment
jerelmiller 9ffc0c2
Clarify comment
jerelmiller b3aedaf
Clarify comment
jerelmiller 913ad14
Remove unneeded test
jerelmiller c229617
Add additional tests for cache-only with partial data
jerelmiller 40800be
Split out test for subscription with defaultContext
jerelmiller e326687
Update test that checks # of unsub with error
jerelmiller bdbb9e3
Don't use mutable object in useQuery
jerelmiller 7f3980f
Remove comment
jerelmiller 82b6e78
Replace of() with EMPTY
jerelmiller 52e4027
Update api report
jerelmiller 682511f
Remove bufferSize from shareReplay
jerelmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rename property to observable
- Loading branch information
commit 711da0878cbef8095ad60ad68ab05a44cf6edf50
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is legacy behavior from
Concast
which would resolve with nothing if there were no sources. I've left this as-is for now, but we'll probably want to revisit this at some point.