Fix a timing problem where useQuery would execute an outdated callback reference.

[phryneas]

This changes the timing to save the callbacks to the ref ever so slightly sooner.
By my testing in the user-supplied reproduction, this fixes #12316 where a cache hit would have triggered setResult before the callback ref could have been updated.

[changeset-bot]

🦋 Changeset detected

Latest commit: 134e5c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed

* (developer-tools)/react/(latest)/data/fragments.mdx

Build ID: b50330828fc68f6022ef305c

URL: https://www.apollographql.com/docs/deploy-preview/b50330828fc68f6022ef305c

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12319

commit: 134e5c3

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	40.67 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.08 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.2 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.18 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.58 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	5.21 KB (+0.02% 🔺)
import { useQuery } from "dist/react/index.js" (production)	4.29 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.7 KB (+0.02% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production)	4.78 KB (0%)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.42 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.17 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.01 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.66 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.09 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.74 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.41 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.35 KB (0%)
import { useFragment } from "dist/react/index.js"	2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	134e5c3
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/6799f0559edbc00008be1111
😎 Deploy Preview	https://deploy-preview-12319--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jerelmiller]

Approved assuming this fixes the reported issue

[jerelmiller]

Given that we will be deprecating onCompleted, can we close this?

[phryneas]

@jerelmiller It might at least make the bug trigger a bit less, and it doesn't add a lot of bundle size, so I'd suggest we still ship this - it just doesn't hurt.