experiment: keep ObservableQuery initiated from useQuery inactive before first subscription

[phryneas]

Triggered by this Discord discussion

Generally, creating a ObservableQuery via watchQuery is already a side effect and adds the query to QueryManager.queries - and it will only be removed if it is subscribed and then unsubscribed.

There might be a number of edge-case scenarios where that is not the case, so this is an attempt from a different angle to solve this problem.

[changeset-bot]

🦋 Changeset detected

Latest commit: b4a06cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[svc-apollo-docs]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 96e5a3c4927b0e8781ac095b

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	b4a06cc
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/67b323cc203cef0008e1d4f0
😎 Deploy Preview	https://deploy-preview-12285--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

npm i https://pkg.pr.new/@apollo/client@12285

commit: b4a06cc

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	41.3 KB (+0.16% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	50.77 KB (+0.17% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	47.85 KB (+0.19% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	36.29 KB (+0.16% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	33.69 KB (+0.19% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.24 KB (0%)
import { useQuery } from "dist/react/index.js"	9.92 KB (+90.35% 🔺)
import { useQuery } from "dist/react/index.js" (production)	8.84 KB (+105.83% 🔺)
import { useLazyQuery } from "dist/react/index.js"	10.39 KB (+82.16% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production)	9.31 KB (+94.79% 🔺)
import { useMutation } from "dist/react/index.js"	3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.84 KB (0%)
import { useSubscription } from "dist/react/index.js"	4.42 KB (+0.03% 🔺)
import { useSubscription } from "dist/react/index.js" (production)	3.48 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.88 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.54 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	5.37 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	4.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.45 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	4.11 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.42 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.36 KB (0%)
import { useFragment } from "dist/react/index.js"	2.36 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.31 KB (0%)

[nikdimm]

@nikdimm

[phryneas]

There is one point I'm a bit concerned about, and that's this:

apollo-client/src/core/QueryManager.ts

Lines 1793 to 1798 in dcc6d5f

	private getQuery(queryId: string): QueryInfo {
	if (queryId && !this.queries.has(queryId)) {
	this.queries.set(queryId, new QueryInfo(this, queryId));
	}
	return this.queries.get(queryId)!;
	}

That means that if we delay registration like this and for whatever reason getQuery gets called (e.g. by a refetch call before the subscription started), a new QueryInfo that doesn't match the QueryInfo from the ObservableQuery gets injected.