Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize useQuery result handling #11954

Merged
merged 11 commits into from
Jul 15, 2024
Merged

optimize useQuery result handling #11954

merged 11 commits into from
Jul 15, 2024

Commits on Jul 11, 2024

  1. remove unused code path 

    Coverage shows that this code path was never hit - in the case of a `standby` fetchPolicy, `resultData.current` would already have been reset in `useResubscribeIfNecessary`
    @phryneas
    phryneas committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1a3e4e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. move code from toQueryResult to setResult 

    While there are three code paths to `toQueryResult`, the other two are guaranteed to never have an `errors` property
    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b5bd2e1 View commit details
    Browse the repository at this point in the history

  2. add undocumented errors field to types and deprecate it

    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3baf15d View commit details
    Browse the repository at this point in the history

  3. remove useHandleSkip 

    instead, we calculate and memoize an "override result" in `useObservableSubscriptionResult`
    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e29e908 View commit details
    Browse the repository at this point in the history

  4. remove now-obsolete originalResult symbol property

    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6261246 View commit details
    Browse the repository at this point in the history

  5. fix typo, chores

    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    037ea25 View commit details
    Browse the repository at this point in the history

  6. adjustment for compiler compat

    @phryneas
    phryneas committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4161379 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge remote-tracking branch 'origin/release-3.11' into pr/useQuery-r… 

    …esult-handling
    @phryneas
    phryneas committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    92127f3 View commit details
    Browse the repository at this point in the history

  2. review feedback

    @phryneas
    phryneas committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e39c253 View commit details
    Browse the repository at this point in the history

  3. changeset

    @phryneas
    phryneas committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a740544 View commit details
    Browse the repository at this point in the history

  4. api-report

    @phryneas
    phryneas committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2456a9a View commit details
    Browse the repository at this point in the history