-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where a merge function that returns an incomplete result would not allow the client to refetch from network #11839
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7bee355
Add test to ensure that a full cache write will rerender errored queries
jerelmiller 2d485f4
Add failing test for partial result
jerelmiller 49f4810
Add comment about expected result
jerelmiller 4a30298
Minor tweak to test description and setup
jerelmiller 73a5667
Update the comment used in setDiff for the updated behavior
jerelmiller 2100d30
Add test to demonstrate expected behavior for incomplete merge functi…
jerelmiller cd811a2
Add changeset
jerelmiller d24003a
Merge branch 'main' into jerel/issue-11759-partial-cache
jerelmiller 5573d21
Merge branch 'main' into jerel/issue-11759-partial-cache
jerelmiller 04f9e83
Merge branch 'main' into jerel/issue-11759-partial-cache
jerelmiller 03615ef
Clean up Prettier, Size-limit, and Api-Extractor
jerelmiller 87d1017
Add test to show that partial cache write does not trigger errored query
jerelmiller 24761c4
Merge branch 'main' into jerel/issue-11759-partial-cache
jerelmiller a4750ee
Clean up Prettier, Size-limit, and Api-Extractor
jerelmiller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@apollo/client": patch | ||
--- | ||
|
||
Fix a regression in [3.9.5](https://github.com/apollographql/apollo-client/releases/tag/v3.9.5) where a merge function that returned an incomplete result would not allow the client to refetch in order to fulfill the query. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
{ | ||
"dist/apollo-client.min.cjs": 39579, | ||
"import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32825 | ||
"dist/apollo-client.min.cjs": 39573, | ||
"import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32821 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't an update be okay in an error-but
returnPartialData: true
case?Staying closer to the previous logic (although I'll admit I'm a bit hazy on some of it)
if ( diff && !diff.complete && + this.observableQuery?.getLastError() && !this.observableQuery?.options.returnPartialData && // In the case of a cache eviction, the diff will become partial so we // schedule a notification to send a network request (this.oqListener) to // go and fetch the missing data. !(oldDiff && oldDiff.complete) ) {