You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#11438 made some changes to remove the retain call from useBackgroundQuery. This was due to allow the query to be disposed of naturally if it was not used by useReadQuery within a given amount of time.
This however introduced a new side effect, which is that the query ref stays "active" when useBackgroundQuery is unmounted before autoDisposeTimeoutMs timeout kicks in. This PR adds a failing test to demonstrate the issue.
This is also problematic when changing variables in useBackgroundQuery before the queryRef is consumed by useReadQuery. The old queryRef will stay active until the autoDisposeTimeoutMs kicks in, in which case it will then be properly disposed. This is also demonstrated in a failing test.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11438 made some changes to remove the
retain
call fromuseBackgroundQuery
. This was due to allow the query to be disposed of naturally if it was not used byuseReadQuery
within a given amount of time.This however introduced a new side effect, which is that the query ref stays "active" when
useBackgroundQuery
is unmounted beforeautoDisposeTimeoutMs
timeout kicks in. This PR adds a failing test to demonstrate the issue.This is also problematic when changing variables in
useBackgroundQuery
before thequeryRef
is consumed byuseReadQuery
. The old queryRef will stay active until theautoDisposeTimeoutMs
kicks in, in which case it will then be properly disposed. This is also demonstrated in a failing test.