Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct language #11157

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Correct language #11157

merged 2 commits into from
Aug 23, 2023

Conversation

Meschreiber
Copy link
Contributor

This PR fixes two small language issues in the Persisted Queries docs:

  • Removes use of "trusted" to make terminology around the feature more concise
  • Names the generatePersistedQueryIdsFromManifest function correctly in code sample descriptions. (Code samples use this function, but it was called generatePersistedQueryIdsAtRuntime, another utility function in the library)

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

⚠️ No Changeset found

Latest commit: 583d321

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.62 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.24 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.39 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.59 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.41 KB (0%)
import { useMutation } from "dist/react/index.js" 2.52 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.5 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.23 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.19 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.73 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.16 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.25 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.67 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.94 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.88 KB (0%)
import { useFragment } from "dist/react/index.js" 2.07 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.02 KB (0%)

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 583d321
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/64e63b2f9aa9340008171036
😎 Deploy Preview https://deploy-preview-11157--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Meschreiber Meschreiber marked this pull request as ready for review August 22, 2023 21:47
@Meschreiber Meschreiber requested a review from a team as a code owner August 22, 2023 21:47
@Meschreiber
Copy link
Contributor Author

@jerelmiller , no rush on this teeny review, just whenever you get a chance. :)

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for updating!

@Meschreiber Meschreiber merged commit 0d8c153 into main Aug 23, 2023
@Meschreiber Meschreiber deleted the docs/pq-update branch August 23, 2023 17:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants