-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set startCursor in relayStylePagination when only one cursor is present #10982
Don't set startCursor in relayStylePagination when only one cursor is present #10982
Conversation
@sdeleur-sc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 9090b82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 This looks great to me and the logic is sound. Great to see you were able to make this change in a way that preserved all the existing logic.
Thanks so much for the contribution!
/release:pr |
Please add a changeset via |
In
relayStylePagination
, thestartCursor
andendCursor
are set based on cursors under the edges if the information is not present under thepageInfo
. This works well when both of the cursors are defined under the nodes. However, if only a single cursor is present, both of the fields get populated with the same cursor, causingstartCursor
andendCursor
to have the same value.This causes an issue on subsequent
merge
operation because thestartCursor
gets written to the first edge here, causing duplicate edges to have the same cursorThe expected behavior here is for only the
endCursor
to be populated and forstartCursor
to remain empty when only a single cursor is present under the edges.Checklist: