Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use React.version as key for shared Contexts #10957

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jun 7, 2023

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 2bae320

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas changed the title Pr/fix 10938 use React.version as key for shared Contexts Jun 7, 2023
@phryneas phryneas marked this pull request as ready for review June 7, 2023 16:29
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 36.55 KB (-0.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 42.95 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.44 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.3 KB (-0.3% 🔽)
import { useQuery } from "dist/react/index.js" 4.34 KB (-0.18% 🔽)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (-0.05% 🔽)
import { useMutation } from "dist/react/index.js" 2.57 KB (-0.16% 🔽)
import { useSubscription } from "dist/react/index.js" 2.34 KB (-0.13% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" 3.45 KB (-0.17% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" 2.88 KB (-0.24% 🔽)
import { useReadQuery } from "dist/react/index.js" 1.65 KB (0%)
import { useFragment } from "dist/react/index.js" 2.12 KB (-0.14% 🔽)

@phryneas
Copy link
Member Author

phryneas commented Jun 7, 2023

/release:pr

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10957-20230607163202.

@jerelmiller
Copy link
Member

You and @alessbell get to duke it out over #10958 which is a duplicate of this one.

@alessbell alessbell merged commit 445164d into release-3.8 Jun 7, 2023
@alessbell alessbell deleted the pr/fix-10938 branch June 7, 2023 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants