Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing useSuspenseQuery tests #10763

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

alessbell
Copy link
Contributor

Makes useSuspenseQuery compatible with changes in #10597.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@alessbell alessbell requested a review from jerelmiller April 13, 2023 21:03
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

⚠️ No Changeset found

Latest commit: ac16e1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need changes from #10762 to make tests pass, but looks great otherwise. Thanks for getting this in there!

@alessbell alessbell merged commit 4bbd7c4 into release-3.8 Apr 13, 2023
@alessbell alessbell deleted the fix/failing-useSuspenseQuery-tests branch April 13, 2023 21:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants