endless loop of requests after updating past 3.0.0-beta.45 #6444
Assignees
Milestone
Comments
capaj
changed the title
capaj
changed the title
|
We just noticed this on a project as well. If it helps for tracking the issue down, whatever's going on is not causing the |
benjamn
added a commit
that referenced
this issue
Jun 16, 2020
Ever since the big refactoring in #6221 made the client more aggressive about triggering network requests in response to incomplete cache data (when using a cache-first FetchPolicy), folks testing the betas/RCs have reported that feuding queries can end up triggering an endless loop of unhelpful network requests. This change does not solve the more general problem of queries competing with each other to update the same data in incompatible ways (see #6372 for mitigation strategies), but I believe this commit will effectively put a stop to most cases of endless network requests. See my lengthy implementation comment for more details, since this is a non-obvious solution to a very tricky problem. Fixes #6307. Fixes #6370. Fixes #6434. Fixes #6444.
|
Without a reproduction I can't be sure, but |
|
confirmed to fix my problem. Thanks for the quick resolution @benjamn. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have a similar problem as #6434, but even without any failed queries.
Just an endless looop of requests. Here's a preview of how the "initiator" tab looks like for one of the requests:
My issue started happening exactly with version 3.0.0-beta.46 and latest I tested is
3.0.0-rc.4which still reproduces the bug.Running my app with 3.0.0-beta.45 works just fine-tested without any other code changes. That version performs great-without any endless requests going out.
Intended outcome:
no request loop
Actual outcome:
there is an endless loop of request coming from my browser to the graphql endpoint
How to reproduce the issue:
Not sure, but I will gladly test out any potential fix. We have an SSR app which has couple of queries hooked into several components in react router. More specifically the page that is suffereing the issue is rendering a https://github.com/JustFly1984/react-google-maps-api component and it's displaying markers in the map.
Also it's got side view which has a regular list and this list has another Graphql query.
Versions
The text was updated successfully, but these errors were encountered: