Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apollo Boost incompatible with TypeScript 3.6 #5367

Closed
hippostar opened this issue Sep 25, 2019 · 1 comment · Fixed by #5373
Closed

Apollo Boost incompatible with TypeScript 3.6 #5367

hippostar opened this issue Sep 25, 2019 · 1 comment · Fixed by #5373

Comments

@hippostar
Copy link

hippostar commented Sep 25, 2019 •
edited
Loading

TypeScript 3.6 removed the GlobalFetch object definition which is still used in packages/apollo-boost/src/index.ts

Observed behavior: Compiling prints this error: TS2304: Cannot find name 'GlobalFetch'
Excepted behavior: No compilation errors.

Someone had a pull request but it didn't get merged, this should be easy to fix.
#5359

Other related issues apollographql/apollo-link#1094
@abdonrd
Copy link
Contributor

abdonrd commented Sep 26, 2019

Ops! Reopened at #5373!

This was referenced Sep 26, 2019
Merged
Closed
tirr-c added a commit to tirr-c/ames-discord that referenced this issue Oct 20, 2019
@tirr-c
Workaround to the apollo-boost typedef bug
68a3b42 
See apollographql/apollo-client#5367
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove reference to GlobalFetch in Typescript abdonrd/apollo-client
2 participants
@abdonrd @hippostar