Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage collection #41

Closed
stubailo opened this issue Mar 26, 2016 · 4 comments
Closed

Garbage collection #41

stubailo opened this issue Mar 26, 2016 · 4 comments

Comments

@stubailo
Copy link
Contributor

In the current code, the store will grow without bound as more and more queries are fetched. We should implement a strategy for clearing out data we are no longer using.

This can be as simple as re-running all of the active queries and putting the results into a new empty store, then throwing away the old one.

@stubailo stubailo added the idea label Mar 26, 2016
@mquandalle
Copy link
Contributor

Could ES6 WeakMaps be of any use here?

@stubailo
Copy link
Contributor Author

That's an interesting idea! On the other hand, I think it would be beneficial to be able to inspect via Redux which items are being garbage collected. If items start unexpectedly disappearing from the store, that might be very confusing. I wonder if we can somehow get both.

@stubailo stubailo modified the milestone: alpha Mar 28, 2016
@martijnwalraven martijnwalraven self-assigned this Apr 6, 2016
@stubailo stubailo added feature and removed idea labels Apr 7, 2016
@stubailo stubailo removed this from the alpha milestone Apr 9, 2016
@stubailo
Copy link
Contributor Author

Relay got this far without having garbage collection at all, so I think this is a pretty low priority right now.

@helfer
Copy link
Contributor

helfer commented Jan 26, 2017

I'm closing this since I think we don't need an issue to keep track of this. a) we're not likely to forget this, and b) project notes would be a better place.

@helfer helfer closed this as completed Jan 26, 2017
jbaxleyiii pushed a commit that referenced this issue Oct 17, 2017
Angular2: Describe service, decorator and examples
jbaxleyiii pushed a commit that referenced this issue Oct 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants