Component not re-render in apollo-link-state after upgrading apollo-cache-inmemory to 1.3.*

[laukaichung]

Intended outcome:

I use apollo link state to save an array of objects to the local client. In apollo-cache-inmemory 1.2.10, the component is able to re-render on pushing new items to the array or deleting one item from the array. After upgrading to 1.3.5, I expected everything would stay the same.

Actual outcome:

However the component fails to re-render at all with 1.3.*.

How to reproduce the issue:

apollo-cache-inmemory 1.2.10:

https://codesandbox.io/s/l99l9r1ml9 (There's an issue with codesandbox. I have to double click the buttons to trigger the re-render, but on my local, there's no such issue.)

apollo-cache-inmemory 1.3.5

https://codesandbox.io/s/8xqn9mz0l (It doesn't work at all, even if I double click either buttons)

Versions

  "dependencies": {
    "graphql": "0.13.2",
    "react": "16.5.0",
    "apollo-cache-inmemory": "1.3.5",
    "apollo-link-state": "^0.4.2",
    "apollo-link-http": "1.5.5",  
    "react-apollo": "2.2.4",
    "react-dom": "16.2.0",
    "apollo-client": "^2.4.2",
    "graphql-tag": "^2.10.0"        
  },

[JoviDeCroock]

Your first and second link have the same behavior for me.

I'm using the latest chrome version, i don't know if this is relevant but just throwing it out there.

[laukaichung]

@JoviDeCroock
Have you tried double clicking on the "Create" button at https://codesandbox.io/s/l99l9r1ml9
I don't know why but codesandbox doesn't re-render on first click. It works fine on the localhost.

[JoviDeCroock]

Yes, maybe i should mention this the same behavior is that they both are working.

[laukaichung]

@JoviDeCroock
Just an update.
Looks like 1.3.5 doesn't work on Chromium (Arch Linux) with this example: https://codesandbox.io/s/8xqn9mz0l
It works on mobile Chrome.

However,
I've also tried the 1.3.5 version in react native but it also doesn't work. I see that the array has been updated in the memory, but the component just doesn't automatically re-render. No errors shown in the console.

[JoviDeCroock]

That's a pretty odd issue, is there some way to reproduce it consistently for others aswell?

[laukaichung]

One more update:
The problem only occurs when it is an array. If the data is a string or integer, the re-rendering works as usual.
Example: https://codesandbox.io/s/71zm7m35o6

[carllippert]

There is some info about this and how state changes are broadcasted in the local-state slack channel provided by @benjamn

[carllippert]

Like to slack comment about a possible work around. https://apollographql.slack.com/archives/C87A16E8Y/p1539111592000100

[laukaichung]

@carllippert
Would you please post the workaround here? I cannot create an account to read. I do not have an @meteor.com email.

[carllippert]

[benjamn]

As a general note, you shouldn't be mutating the results returned from the cache, unless you are careful to re-write them immediately, since those objects may be returned for future reads. Make copies of the data you read from the cache, if you plan on changing the contents of the objects.

If I'm diagnosing this problem correctly, perhaps we should be Object.freeze-ing cache results?

[OurMajesty]

Having the same issue.
1.2.10 - no problem, 1.3.5 did not rerender.
Instructions on screenshot didn't help.

[OurMajesty]

1.3.0-beta.15 did work, BTW
sorry, mistaken. beta doesn't work either

[benjamn]

@OurMajesty Can you put together a small reproduction?