readQuery and readFragment do (can) not return optimistic data

[jer-sen]

After processing an optimistic response and before receiving the response from the server, if readQuery or readFragment is called from ApolloClient, it returns data ignoring the optimistic update.
I think the optimistic data should be returned instead. It would be coherent with the data available through observable queries.
At least, there should be an option ("optimistic:: true" ?) to let the user decide which version of the data return.

[jbaxleyiii]

@Jay1337 I think there is a way to do this actually, you should be able to specify the optimistic nature of the response:

https://github.com/apollographql/apollo-client/blob/master/packages/apollo-cache/src/cache.ts#L69-L72

[jer-sen]

@jbaxleyiii You can access to optimistic from the Cache object but not from the ApolloClient object.

You can have a look at the ApolloClient code : https://github.com/apollographql/apollo-client/blob/master/packages/apollo-client/src/ApolloClient.ts

To get an optimistic response from the Cache you have to provide a second argument being true to the readQuery or readFragment functions. But ApolloClient's functions readQuery or readFragment never set this second argument when calling the Cache's functions...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Apollo Client!

[jer-sen]

Hey !

[jbaxleyiii]

@Jay1337 heads up that I'm going to be turning off stalebot next week (getting ready to have Thanksgiving holidays in the US)

[hwillson]

To help provide a more clear separation between feature requests / discussions and bugs, and to help clean up the feature request / discussion backlog, Apollo Client feature requests / discussions are now being managed under the https://github.com/apollographql/apollo-feature-requests repository.

Migrated to: apollographql/apollo-feature-requests#14