Remove string from reduxRootSelector in ApolloClient constructo…

…r is it was misleading (#1891) * allow `reduxRootSelector ` to be used as a reduxRootKey * cleanup string * remove redundant test
apollographql · Jul 13, 2017 · fc826c3 · fc826c3
1 parent 09e4e27
commit fc826c3
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/ApolloClient.ts b/src/ApolloClient.ts
@@ -177,7 +177,7 @@ export default class ApolloClient implements DataProxy {
 
   constructor(options: {
     networkInterface?: NetworkInterface | ObservableNetworkInterface,
-    reduxRootSelector?: string | ApolloStateSelector,
+    reduxRootSelector?: ApolloStateSelector,
     initialState?: any,
     dataIdFromObject?: IdGetter,
     ssrMode?: boolean,

diff --git a/test/client.ts b/test/client.ts
@@ -208,11 +208,6 @@ describe('client', () => {
     );
   });
 
-  it('should not allow passing reduxRootSelector as a string', () => {
-    const reduxRootSelector = 'testApollo';
-    assert.throws( () => new ApolloClient({ reduxRootSelector }));
-  });
-
   it('should throw an error if "reduxRootSelector" is provided and the client tries to create the store', () => {
     const reduxRootSelector = (state: any) => state.testApollo;
     const client = new ApolloClient({