Skip to content

Commit

Permalink
Correct the frame test.
Browse files Browse the repository at this point in the history
This removes the UNNEEDED_FRAME from the second test added in PR #9508,
which currently causes the test to fail, though the version without the
UNNEEDED_FRAME is how we ultimately want useQuery to behave.

I believe the other test is correct to have the repeated frame:
#9508 (comment)
  • Loading branch information
benjamn committed Apr 14, 2022
1 parent db0bd4b commit 85ae61f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/react/hooks/__tests__/useQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ describe('useQuery Hook', () => {
expectFrames(result, [
{ loading: true, data: void 0, networkStatus: NetworkStatus.loading },
{ loading: false, data: { hello: "world 1" }, networkStatus: NetworkStatus.ready },
UNNEEDED_FRAME,
// UNNEEDED_FRAME,
{ loading: true, data: void 0, networkStatus: NetworkStatus.setVariables },
{ loading: false, data: { hello: "world 2" }, networkStatus: NetworkStatus.ready },
]);
Expand Down

0 comments on commit 85ae61f

Please sign in to comment.