refactor(cache): use Record<string, any> as the default Entity type

Use a more appropriate real-life default type for `cache.modify`.
apollographql · Jun 2, 2023 · 3681939 · 3681939
1 parent c845531
commit 3681939
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/cache/core/cache.ts b/src/cache/core/cache.ts
@@ -117,7 +117,7 @@ export abstract class ApolloCache<TSerialized> implements DataProxy {
     return [];
   }
 
-  public modify<Entity = any>(options: Cache.ModifyOptions<Entity>): boolean {
+  public modify<Entity = Record<string, any>>(options: Cache.ModifyOptions<Entity>): boolean {
     return false;
   }
 

diff --git a/src/cache/core/types/Cache.ts b/src/cache/core/types/Cache.ts
@@ -57,7 +57,7 @@ export namespace Cache {
     discardWatches?: boolean;
   }
 
-  export interface ModifyOptions<Entity = any> {
+  export interface ModifyOptions<Entity = Record<string, any>> {
     id?: string;
     fields: Entity extends Record<string, unknown>
       ? Modifiers<Entity> | Modifier<Entity>

diff --git a/src/cache/inmemory/inMemoryCache.ts b/src/cache/inmemory/inMemoryCache.ts
@@ -204,7 +204,7 @@ export class InMemoryCache extends ApolloCache<NormalizedCacheObject> {
     }
   }
 
-  public modify<Entity = any>(options: Cache.ModifyOptions<Entity>): boolean {
+  public modify<Entity = Record<string, any>>(options: Cache.ModifyOptions<Entity>): boolean {
     if (hasOwn.call(options, "id") && !options.id) {
       // To my knowledge, TypeScript does not currently provide a way to
       // enforce that an optional property?:type must *not* be undefined