Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error caused by undefined schemas #307

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Fix error caused by undefined schemas #307

merged 1 commit into from
Oct 30, 2020

Conversation

jcreighton
Copy link
Contributor

Issued with #286 - we didn't check that schemas existed.

I am grateful that we'll be able to avoid bugs like this in the future codebase. 🙏

@jcreighton jcreighton mentioned this pull request Oct 30, 2020
Closed
hwillson
hwillson approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @jcreighton!

@jcreighton jcreighton merged commit e169a7b into master Oct 30, 2020
@jcreighton jcreighton deleted the schemas-undefined branch October 30, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcreighton @hwillson