Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save introspectionQuery results in the cache #273

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

jcreighton
Copy link
Contributor

@jcreighton jcreighton commented Jun 2, 2020

Previously, we did not pass the fetchPolicy through to the cache replica, which results in the introspection query being saved to the cache. These queries could be large enough to slow down or crash the devtools.

Fixes #271 and #231.

@jcreighton jcreighton force-pushed the fix-schema-inclusion branch 2 times, most recently from 970cc0a to d1bce7c Compare June 2, 2020 00:52
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @jcreighton, looks great - thanks very much!

@jcreighton jcreighton merged commit 6cf895a into master Jun 2, 2020
@jcreighton jcreighton deleted the fix-schema-inclusion branch June 2, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache tab freezes and crashed
2 participants