Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix scroll in sidebar and main view of cache #225

Merged
merged 5 commits into from
Sep 14, 2019

Conversation

sagarhani
Copy link
Contributor

This will fix scroll in #187 and also in sidebar.

@apollo-cla
Copy link

@sagarhani: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@charlotte-miller
Copy link

Related: #217

@dko-slapdash
Copy link

dko-slapdash commented Sep 9, 2019

Scrolling in both Chrome extension and GraphQL playground don't currently work, I just pulled the latest version. I hope merging this commit will fix both issues.

@slavanossar
Copy link

Also maybe consider replacing overflow: scroll with overflow-y: auto on .inspector-sidebar, so the scrollbar is only visible when needed.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sagarhani!

@hwillson hwillson merged commit cb0e7f4 into apollographql:master Sep 14, 2019
@hwillson
Copy link
Member

2.2.5 is now available in the Chrome store, and it includes this fix. Thanks!

woahitsraj pushed a commit to woahitsraj/apollo-client-devtools that referenced this pull request Oct 15, 2019
* 🐛 Fix scroll in sidebar and main view of cache

* Slight tweak to add scrolling in non-dark mode

* Changelog update

* Version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants