Prepare to publish to npm (add README for npm and add version to package.json) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheapsteak
changed the title
|
Hey @cheapsteak, would it be possible to follow same version as in manifest.json file? I see that version is necessary for checkVersions and it would be easier to import the version from package.json, than from manifest. |
In preparation for #160
cheapsteak
force-pushed
the
chang/publish-to-npm
branch
from
9a5bc3c
to
8789287
Compare
|
@Gongreg good point, I've set it to 2.1.6 now |
hwillson
approved these changes
Jan 24, 2019
There was a problem hiding this comment.
Awesome @cheapsteak - one small suggested tweak, but not a showstopper. Thanks!
Co-Authored-By: cheapsteak <cheapsteak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #160
The
READMEfile is the one that's shown for npm, hopefully this would mitigate confusion if anyone finds this package via npm search